Draft
Conversation
Member
imantsk
commented
Dec 11, 2025
imantsk
commented
- Add required translators comments for placeholder strings
- Escape translatable output in AJAX/version switch/import flows
- Escape cloud search list action links
- Prefix globals/locals to satisfy naming checks in loader and views
sheabunge
requested changes
Dec 12, 2025
|
|
||
| } else { | ||
| $imported_count = sprintf( '<strong>%s</strong>', esc_html( number_format_i18n( $imported ) ) ); | ||
| printf( |
Member
There was a problem hiding this comment.
printf seems redundant here. What are we intending to achieve with this change?
| </div> | ||
| </h3> | ||
| <ul class="action-buttons"> | ||
| <?php echo wp_kses_post( cloud_lts_build_action_links( $item, 'search' ) ); ?> |
Member
There was a problem hiding this comment.
I believe this will break the thickbox script. Escaping isn't necessary here – if we want to improve compliance, the underlying function really should be refactored to do output itself.
|
|
||
| if ( $install_result ) { | ||
| delete_transient( VERSION_CACHE_KEY ); | ||
| if ( $install_result ) { |
Member
There was a problem hiding this comment.
Looks like this introduces some incorrect indentation.
| * @var Manage_Menu $this | ||
| */ | ||
|
|
||
| $search_query = isset( $_REQUEST['cloud_search'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['cloud_search'] ) ) : ''; |
| <form method="get" action="" id="cloud-search-form"> | ||
| <?php List_Table::required_form_fields( 'search_box' ); ?> | ||
| <label class="screen-reader-text" for="cloud_search"> | ||
| <?php esc_html_e( 'Search cloud snippets', 'code-snippets' ); ?> |
Member
There was a problem hiding this comment.
Introduces incorrect indentation.
imantsk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.